New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.eliot: init at 1.12.0 #91049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
>>> eliot.to_file(sys.stdout)
{"action_status": "started", "timestamp": 1592499601.585768, "task_uuid": "9844c459-f723-480c-8a47-22c5a5347ff5", "action_type": "", "task_level": [1]}
{"action_status": "started", "timestamp": 1592499616.634578, "task_uuid": "c995b315-6828-49c5-ad58-edc9b719090e", "action_type": "", "task_level": [1]}
{"exception": "builtins.NameError", "reason": "name 'Hello' is not defined", "action_status": "failed", "timestamp": 1592499616.6350558, "task_uuid": "c995b315-6828-49c5-ad58-edc9b719090e", "action_type": "", "task_level": [2]}
>>> with eliot.start_task():
... print("hello")
... raise Hello()
...
{"action_status": "started", "timestamp": 1592499705.849607, "task_uuid": "9d3bd3e5-d167-4f5d-9b2a-b9a0c75ab835", "action_type": "", "task_level": [1]}
hello
{"exception": "builtins.NameError", "reason": "name 'Hello' is not defined", "action_status": "failed", "timestamp": 1592499705.849977, "task_uuid": "9d3bd3e5-d167-4f5d-9b2a-b9a0c75ab835", "action_type": "", "task_level": [2]}
Traceback (most recent call last):
File "<stdin>", line 3, in <module>
NameError: name 'Hello' is not defined
# Has a huge dependency graph for tests | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests are not available, then please use pythonImportsCheck
to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.
let | ||
pname = "eliot"; | ||
version = "1.12.0"; | ||
|
||
in buildPythonPackage { | ||
inherit pname version; | ||
|
||
src = fetchPypi { | ||
inherit pname version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most common format
let | |
pname = "eliot"; | |
version = "1.12.0"; | |
in buildPythonPackage { | |
inherit pname version; | |
src = fetchPypi { | |
inherit pname version; | |
buildPythonPackage rec { | |
pname = "eliot"; | |
version = "1.12.0"; | |
src = fetchPypi { | |
inherit pname version; |
description = "Eliot: the logging system that tells you *why* it happened."; | ||
homepage = "https://eliot.reathedocs.io"; | ||
license = lib.licenses.asl20; | ||
maintainers = [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add yourself as a maintainer
|
||
meta = { | ||
description = "Eliot: the logging system that tells you *why* it happened."; | ||
homepage = "https://eliot.reathedocs.io"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo readthedocs
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)