Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: 3.2.0 -> 3.3.0 #91095

Merged
merged 1 commit into from
Jun 23, 2020
Merged

bazel: 3.2.0 -> 3.3.0 #91095

merged 1 commit into from
Jun 23, 2020
+73 −36

Conversation

avdv
Copy link
Member

@avdv avdv commented Jun 19, 2020

Motivation for this change

Bazel 3.3.0 release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@uri-canva
Copy link
Contributor

Tested on macOS, works.

Profpatsch
Profpatsch approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Profpatsch Profpatsch merged commit 21a21a4 into NixOS:master Jun 23, 2020
@avdv avdv deleted the bazel-3.3.0 branch June 23, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch

@FRidh FRidh

@jonringer jonringer

@andrew-d andrew-d

@kalbasit kalbasit

@uri-canva uri-canva

@mboes mboes

@timokau timokau

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avdv @uri-canva @Profpatsch