Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nixops: update boto3, botocore and awscli #91047

Closed
wants to merge 3 commits into from
Closed

Fix Nixops: update boto3, botocore and awscli #91047

wants to merge 3 commits into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jun 18, 2020 •
edited

Motivation for this change

boto3 is currently broken because it is not compatible with botocore. Since nixops depends on boto3, it is also broken.
awscli is updated to build with the new botocore version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member Author

nlewo commented Jun 18, 2020

@GrahamcOfBorg build nixops awscli pythonPackages.boto3 pythonPackages.botocore

@flokli
Copy link
Contributor

flokli commented Jun 18, 2020

There's already other versions of boto* in staging-next - see #90627.

If nixops only works with specific versions of it, and can't keep up, it'd probably be better if it'd use pinned versions internally.

@nlewo
Copy link
Member Author

nlewo commented Jun 18, 2020

Oh!
I actually did a Github search but nothing was found because your PR is closed and I didn't think about staging-*.

nixops is just broken because boto3 is broken.

Thanks!

@nlewo nlewo closed this Jun 18, 2020
@flokli flokli mentioned this pull request Jun 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlewo @flokli