Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultGemConfig.mathematical: fix cross compilation #91077

Merged
merged 1 commit into from Jul 10, 2020
Merged

defaultGemConfig.mathematical: fix cross compilation #91077

merged 1 commit into from Jul 10, 2020

Conversation

expipiplus1
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

I suggest also passing strictDeps = true; as that helps determining whether the deps are in the right place.

@FRidh FRidh added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jun 19, 2020
@expipiplus1
Copy link
Contributor Author

@FRidh I have no idea about ruby packaging, but I had to add several libraries to buildinputs and add ruby to nativebuildinputs after I enabled strictdeps.

@expipiplus1
Copy link
Contributor Author

Possible to get this merged?

@FRidh FRidh merged commit f6e07b3 into NixOS:master Jul 10, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jul 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @FRidh