Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fedora-coreos-config-transpiler: init at 0.6.0 #91057

Merged
merged 2 commits into from Jun 19, 2020
Merged

fedora-coreos-config-transpiler: init at 0.6.0 #91057

merged 2 commits into from Jun 19, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Jun 18, 2020

Motivation for this change

We package the CoreOS Container Linux Config Transpiler, but CoreOS Container Linux has reached end of life, and has been superseded by Fedora CoreOS. The Fedora CoreOS Config Transpiler (FCCT) is the equivalent config transpiler for Fedora CoreOS.

I am not removing the original Container Linux Config Transpiler, because Container Linux lives on in Flatcar Linux.

The new package is a copy of the container-linux-config-transpiler package, with metadata updated and postInstall slightly simplified.

@pop I added you as a maintainer because you are the maintainer of the original config transpiler package, are you okay with that?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli
flokli reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion, and some style nitpicks (probably just copypasta from pkgs/development/tools/container-linux-config-transpiler/default.nix.

pkgs/development/tools/fedora-coreos-config-transpiler/default.nix Outdated
description = "Translates Fedora CoreOS configs into Ignition configs";
license = licenses.asl20;
homepage = "https://github.com/coreos/fcct";
maintainers = with maintainers; [elijahcaine ruuda];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with maintainers; [elijahcaine ruuda];
maintainers = with maintainers; [ elijahcaine ruuda ];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, applied.

pkgs/development/tools/fedora-coreos-config-transpiler/default.nix Outdated
license = licenses.asl20;
homepage = "https://github.com/coreos/fcct";
maintainers = with maintainers; [elijahcaine ruuda];
platforms = with platforms; unix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = with platforms; unix;
platforms = platforms.unix;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, applied.

pkgs/development/tools/fedora-coreos-config-transpiler/default.nix Outdated Show resolved Hide resolved
@ruuda
fedora-coreos-config-transpiler: init at 0.6.0
9e887cf 
Fedora CoreOS Config Transpiler (FCCT) is to Fedora CoreOS what
Container Linux Config Transpiler (CT) was to CoreOS Container Linux.
@ruuda
fedora-coreos-config-transpiler: use buildGoModule
05c559c
@ofborg ofborg bot requested a review from kalbasit June 19, 2020 07:06
@flokli flokli merged commit f48db61 into NixOS:master Jun 19, 2020
@ruuda ruuda mentioned this pull request Jul 18, 2020
Merged
10 tasks
@ruuda ruuda deleted the fcct branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruuda @flokli