Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-basicauth: init at 0.2.0 #90762

Closed
wants to merge 1 commit into from
Closed

pythonPackages.flask-basicauth: init at 0.2.0 #90762

wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Jun 18, 2020

Motivation for this change

I updated the locustio package but it required this one. Last release seems
quite old so the tests fail because they haven't been updated to match modern
flask. Hopefully the locust package will drop this dependency in future
releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
pythonPackages.flask-basicauth: init at 0.2.0
6e19aa1 
Required depencendy before updating the locustio package.
@teto
Copy link
Member Author

teto commented Sep 5, 2020

I know use poetry2nix for these kinds of low usage packages.

@teto teto closed this Sep 5, 2020
@teto teto deleted the flask-basicauth branch September 5, 2020 22:27
@wesnel wesnel mentioned this pull request Aug 4, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@teto