Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/wasabibackend: init 1.1.11.1 #90884

Merged
merged 4 commits into from Jun 20, 2020
Merged

nixos/wasabibackend: init 1.1.11.1 #90884

merged 4 commits into from Jun 20, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jun 18, 2020

Motivation for this change

Adding the backend service for wasabiwallet, a coinjoin thingy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmilata
mmilata reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was excited to see this & didn't notice that it's a draft at first. Left some suggestions anyway.

nixos/modules/services/networking/wasabibackend.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/wasabibackend.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/wasabibackend.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/wasabibackend.nix Show resolved Hide resolved
@mmahut
Copy link
Member Author

mmahut commented Jun 18, 2020

Was excited to see this & didn't notice that it's a draft at first. Left some suggestions anyway.

Yes, still some work to finish on this one before it is ready :)

@mmahut mmahut changed the title nixos/wasabiwallet: init 1.1.11.1 nixos/wasabibackend: init 1.1.11.1 Jun 18, 2020
@mmahut
Copy link
Member Author

mmahut commented Jun 19, 2020

@GrahamcOfBorg test wasabibackend

@mmahut
Copy link
Member Author

mmahut commented Jun 19, 2020

Okay, tested and it is working fine. It is ready for review now.

@mmahut mmahut marked this pull request as ready for review June 19, 2020 16:10
@mmahut mmahut requested review from 1000101 and mmilata June 19, 2020 16:11
@mmahut @1000101
nixos/wasabibackend: fixing description
d07ba3e 
Co-authored-by: 1000101 <b1000101@pm.me>
mmilata
mmilata approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with dotNet packaging (.dll? bitcoind.exe??:D) but the module looks good.

nixos/tests/wasabibackend.nix Show resolved Hide resolved
@mmahut mmahut merged commit 0ff1bdb into NixOS:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@1000101 1000101 1000101 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @mmilata @1000101