iso-image: add 'serial console' boot entry #91086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is the final step of making installation via serial not fiddly, as described in #58198 .
Prior to this commit, installation over serial console would requiring
manually having to modify the kernel modeline.
This is unnecessarily fiddly, so this commit adds a syslinux boot
entry that has serial enabled.
GRUB already has a serial console entry:
nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix
Lines 311 to 317 in 2c07a08
Why 115200 bps? This is already used in other places, e.g. #58196
I tested this change by building the image, booting the image, and
observing the boot process over serial:
Fixes #58198
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)