Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #91090

Closed
wants to merge 3 commits into from
Closed

Staging next #91090

wants to merge 3 commits into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar referenced this pull request Jul 14, 2020
This is a very common path that often collides with other packages.
jtojnar referenced this pull request Jul 14, 2020
This is a very common path that often collides with other packages.
@flokli flokli mentioned this pull request Jul 16, 2020
10 tasks
@flokli
Copy link
Contributor

flokli commented Jul 16, 2020

@vcunat how's the status of this? Can we merge this and open another staging round?

Asking mostly because of https://github.com/NixOS/nixpkgs/pull/93128…

@vcunat
Copy link
Member

vcunat commented Jul 16, 2020

This iteration had been merged in 377324c. I verified that staging-next still only contains merges from master in addition to master commits; I have no idea why GitHub hasn't closed this PR.

@vcunat
Copy link
Member

vcunat commented Jul 19, 2020

Next iteration: #93465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants