Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librespot: init at 0.1.1 #91015

Merged
merged 1 commit into from Jun 19, 2020
Merged

librespot: init at 0.1.1 #91015

merged 1 commit into from Jun 19, 2020

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Jun 18, 2020 •
edited

Motivation for this change

Add a package for the librespot application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@balsoft
Copy link
Member

balsoft commented Jun 18, 2020

Builds & runs on nixos:

$ nix shell github:bennofs/nixpkgs/init-librespot#librespot -c librespot -n test
[2020-06-18T22:26:38Z INFO  librespot] librespot  (). Built on 2020-06-18. Build ID: XQymNwSs

I don't have a spotify subscription, so can't test further.

@bennofs bennofs merged commit 6580c59 into NixOS:master Jun 19, 2020
@bennofs bennofs deleted the init-librespot branch June 19, 2020 11:07
@bachp bachp mentioned this pull request Aug 9, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bennofs @balsoft