Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] chromedriver: 81.0.4044.69 -> 83.0.4103.39 #91012

Merged
merged 1 commit into from Jun 23, 2020

Conversation

nixy
Copy link
Contributor

@nixy nixy commented Jun 18, 2020

Motivation for this change

Bring in sync with chromium versino, so that chromedriver and chromium can be used together.
Chromium 83 was backported to 20.03 without an update to chromedriver, so chromedriver can't be used in the current release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from marsam and cillianderoiste June 18, 2020 13:20
@nixy nixy changed the title chromedriver: 81.0.4044.69 -> 83.0.4103.39 [20.03] chromedriver: 81.0.4044.69 -> 83.0.4103.39 Jun 18, 2020
@mweinelt
Copy link
Member

Maybe it's time to add a comment to the chromium package that the chromedriver version should be kept in sync.

@nixy
Copy link
Contributor Author

nixy commented Jun 22, 2020

Maybe it's time to add a comment to the chromium package that the chromedriver version should be kept in sync.

There was some discussion of this and other solutions in this thread on discourse.

I definitely think something is needed, but not sure if that is in scope for getting this backported.

@marsam marsam merged commit fb6c3a6 into NixOS:release-20.03 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants