Fix GCC cross compilation #91089
Closed
Fix GCC cross compilation #91089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross compiling ghc, we end up with the sanitizer libraries in , however they still refer to (in their rpaths in the so's). Thus we have a cycle -> -> , and nix will complain. I'm not sure why they multi-output logic doesn't patchelf the rpaths, but it apparently doesnt.
|
This is a hack, I'd be happy to be informed about a better solution. |
|
@angerman informs me this is mac -> linux cross compilation in particular. |
|
Sounds like what is being discussed in #88213. |
| @@ -88,7 +88,7 @@ stdenv.mkDerivation ({ | |||
|
|
|||
| inherit patches; | |||
|
|
|||
| outputs = [ "out" "man" "info" ] ++ stdenv.lib.optional (!langJit) "lib"; | |||
| outputs = [ "out" "man" "info" ] ++ stdenv.lib.optional (!langJit && targetPlatform == hostPlatform) "lib"; | |||
There was a problem hiding this comment.
we definitely want the lib output in cross so that our cross closures don't accidentally pull in the compiler
There was a problem hiding this comment.
I’m not questioning that. This is just what breaks it right now.
|
Indeed looks like this is a duplicate of #88213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling ghc, we end up with the sanitizer libraries in $lib,
however they still refer to (in their rpaths in the so's). Thus we
have a cycle $lib -> $out -> $lib, and nix will complain. I'm not sure
why they multi-output logic doesn't patchelf the rpaths, but it apparently
doesn't.