Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia: unbreak on darwin #91056

Closed
wants to merge 3 commits into from
Closed

sequoia: unbreak on darwin #91056

wants to merge 3 commits into from

Conversation

puzzlewolf
Copy link
Contributor

@puzzlewolf puzzlewolf commented Jun 18, 2020 •
edited

Motivation for this change

This is an attempt to unbreak sequoia on darwin. I don't own a Mac, so I'm trying to get ofBorg to do the work :)

sequoia has been marked broken on Darwin since #73104 (version 0.11.0). I'd like to check if the build still fails and try to fix it, if it does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 18, 2020
@puzzlewolf puzzlewolf marked this pull request as ready for review June 18, 2020 17:56
@puzzlewolf puzzlewolf marked this pull request as draft June 18, 2020 17:56
@puzzlewolf
Copy link
Contributor Author

Hmm, there is no build attempt for darwin. Is there a way to make this work, or am I trying something I shouldn't?

@puzzlewolf puzzlewolf changed the title [WIP] sequoia: unbreak on darwin sequoia: unbreak on darwin Jun 19, 2020
@puzzlewolf
Copy link
Contributor Author

Remove "[WIP]" from title to make ofBorg build the package, from the readme:

If the title of a PR begins with WIP:, contains [WIP] anywhere, or has the 2.status: work-in-progress label, its packages are not built automatically. Note: Marking a PR as a draft does not prevent automatic builds.

I guess I'm not allowed to, but let's try:
@ofborg build sequoia

@puzzlewolf
sequoia: 0.16.0 -> 0.17.0
a8c4758
@puzzlewolf
sequoia: exclude tests for 'sequoia-store'
3e90c5c 
Tests for 'sequoia-store' often error with 'Too many open filehandles'
on ofBorg and Hydra. Exclude them until a better solution
can be found.
@puzzlewolf
sequoia: remove broken marker for darwin
8080f88
@ofborg ofborg bot requested a review from doronbehar June 19, 2020 14:32
@puzzlewolf
Copy link
Contributor Author

@doronbehar I see you are a trusted user for ofBorg. Could you please trigger a build on darwin?

@doronbehar
Copy link
Contributor

@doronbehar I see you are a trusted user for ofBorg. Could you please trigger a build on darwin?

I appreciate your enthusiasm regarding this package and your motivation to make it build on Darwin, but TBH I don't see much point in this effort, as long as you are not a Darwin user yourself. Let somebody else put on the effort. For completeness, I'd keep this PR open as a draft and perhaps open /or search if an issue's already open for Sequoia's Darwin support so it will be a bit noticable if someone will seek that in the future.

To answer your question, the answer is NO. Building this package is already expensive and I'm not willing to make ofborg test it while it's not tested at all on a human's machine.

@puzzlewolf
Copy link
Contributor Author

Hm, ok. That makes sense. Thanks for explaining :)

@puzzlewolf
Copy link
Contributor Author

Closing, since #101753 sequoia is no longer marked as broken :)

@puzzlewolf puzzlewolf closed this Mar 3, 2021
@puzzlewolf puzzlewolf deleted the sequoia_0.17.0_darwin branch March 3, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puzzlewolf @doronbehar @ryantm