[20.03] qemu: patch CVE-2020-1711 #91093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs124
approved these changes
Jun 19, 2020
|
Wrong branch? Shouldn't this go to release-20.03? |
|
nix-review seems happy for me on macos 10.14, patch looks a-ok too |
|
@ajs124 oops... rebasing |
ckauhaus
force-pushed
the
88387-fix-qemu-CVE-2020-1711
branch
from
693bcd5
to
f9fd435
Compare
|
another try :) |
dasJ
approved these changes
Jun 28, 2020
jonringer
reviewed
Jun 28, 2020
| @@ -84,6 +84,11 @@ stdenv.mkDerivation rec { | |||
| stripLen = 1; | |||
| extraPrefix = "slirp/"; | |||
| }) | |||
| (fetchpatch { | |||
There was a problem hiding this comment.
do you mind adding a reason, and timeline for removing the patch?
Suggested change
| (fetchpatch { | |
| # fixes x,y,z . Can be removed next minor/patch. | |
| (fetchpatch { |
There was a problem hiding this comment.
i guess the patch name mentions the CVE
There was a problem hiding this comment.
Oops, overlooked your comment. Patch will be obsolete in 4.2.1, just FTR.
jonringer
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a high profile risk identified in #88387 and a patch is readily available. So we should fix this one first.
No action required on nixos-unstable.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)