Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmilter: fix compilation on Darwin #88075

Merged
merged 4 commits into from Jun 11, 2020
Merged

libmilter: fix compilation on Darwin #88075

merged 4 commits into from Jun 11, 2020

Conversation

mroi
Copy link
Contributor

@mroi mroi commented May 18, 2020

This PR fixes compilation of libmilter on Darwin.

Motivation for this change

I am trying to enable compilation of clamav on Darwin and libmilter is a prerequisite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mroi added 4 commits May 18, 2020 17:38
@mroi
libmilter: set MILTER_SOVER
218d7c5 
MILTER_SOVER is used as an environment variable during the build, but never set anywhere
set to so version 1 as currently used by Ubuntu
@mroi
libmilter: configurable shared object extension
c9d8eda 
defaults to ‘so’ if not set
@mroi
libmilter: install archive as not executable
81fed3c
@mroi
libmilter: fix compilation on Darwin
cb38977 
* configure compilation options
* patch sendmail.h header inclusion
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2020
@ofborg ofborg bot requested a review from fpletz May 18, 2020 16:38
@matthewbauer matthewbauer merged commit d659f96 into NixOS:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroi @matthewbauer