Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reaper: update to 6.10, fix libjack2 missing dependency #88049

Merged
merged 2 commits into from May 24, 2020
Merged

reaper: update to 6.10, fix libjack2 missing dependency #88049

merged 2 commits into from May 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2020 •
edited by ghost

Motivation for this change

Closes #79763
Closes #80486

cc @bignaux @t-cip

jack

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from jfrankenau and worldofpeace May 18, 2020 06:44
@ghost ghost mentioned this pull request May 18, 2020
Closed
10 tasks
@veprbl veprbl mentioned this pull request May 24, 2020
Closed
@veprbl veprbl merged commit 03aca5b into NixOS:master May 24, 2020
@ghost
Copy link
Author

ghost commented May 25, 2020

@veprbl Thank you!

@ghost ghost deleted the reaper branch May 25, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated package: reaper-5.981 Reaper – jack backend not configured
3 participants
@prusnak @veprbl @bignaux