Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doas: enable timestamp by default and set pamdir #88028

Merged
merged 1 commit into from May 17, 2020
Merged

doas: enable timestamp by default and set pamdir #88028

merged 1 commit into from May 17, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 17, 2020

  • --with-timestamp enables the usage of the persist setting in
    doas.conf. It is possible some people might not want this, so the flag
    withTimestamp was added to control this.
  • --pamdir copies the PAM files to $out/etc/pam.d. This may or may
    not have a use in the future, but it removes a some errors from the
    build (when it tries to copy these files to /etc/pam.d).
Motivation for this change

The persist setting from nixos/doas will not actually work because you must opt in to timestamps (its presence when this is disabled will be silently ignored).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
doas: enable timestamp by default and set pamdir
0f8e972 
* `--with-timestamp` enables the usage of the `persist` setting in
`doas.conf`. It is possible some people might not want this, so the flag
`withTimestamp` was added to control this.
* `--pamdir` copies the PAM files to `$out/etc/pam.d`. This may or may
not have a use in the future, but it removes a some errors from the
build (when it tries to copy these files to /etc/pam.d).
@cole-h cole-h requested a review from adisbladis May 17, 2020 18:44
@adisbladis
Copy link
Member

@GrahamcOfBorg test doas

@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@adisbladis adisbladis merged commit a78d9d6 into NixOS:master May 17, 2020
@cole-h cole-h deleted the doas branch May 17, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @adisbladis