Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: 4.92.3 -> 4.93 #88079

Merged
merged 1 commit into from May 19, 2020
Merged

exim: 4.92.3 -> 4.93 #88079

merged 1 commit into from May 19, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented May 18, 2020

As per the updating notes, DISABLE_TLS replaces SUPPORT_TLS.
The build system also wants you to choose between OpenSSL and GnuTLS.
Since we were using OpenSSL until now, I chose that.

Motivation for this change

Upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I also checked that the 3 non-standard options (enableLDAP, enableMySQL and enablePAM) still compile, but I did not check if they work correctly.

@ofborg ofborg bot requested a review from 4z3 May 18, 2020 17:21
@ajs124
exim: 4.92.3 -> 4.93.0.4
7ed1c6f 
As per the updating notes[1], DISABLE_TLS replaces SUPPORT_TLS.
The build system also wants you to choose between OpenSSL and GnuTLS.
Since we were using OpenSSL until now, I chose that.

[1]: https://git.exim.org/exim.git/blob_plain/885bb037cb791e057de2105bb3790c6135914c62:/src/README.UPDATING
@Lassulus Lassulus merged commit b32a59d into NixOS:master May 19, 2020
@ajs124 ajs124 deleted the upd/exim branch May 19, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4z3 4z3 Awaiting requested review from 4z3

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @Lassulus