Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: optionally wrap mediaplayer.py #88080

Merged
merged 1 commit into from May 22, 2020
Merged

waybar: optionally wrap mediaplayer.py #88080

merged 1 commit into from May 22, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented May 18, 2020

This is a continuation of #85507 that I brok with a force push.

Motivation for this change

waybar has a mediaplayer.py script that uses mpris to show the current song.

Things done

Quite a package closure size increase.

No idea if I should use preFixup or another phase.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/igjl73fjbg42hdk4di4bpjb6gypjx3cl-waybar-0.9.2 202.7M
/nix/store/fg8j6fq4pqziscjnvy1lry96hb2k6pxa-waybar-0.9.2 847.6M

@bbigras
Copy link
Contributor Author

bbigras commented May 18, 2020

I added playerctl back because we get:

[nix-shell:~/.cache/nixpkgs-review/pr-85507-1]$ result/bin/waybar-mediaplayer.py
Traceback (most recent call last):
  File "/nix/store/dygl1b2k1rdxylnzq5w0m8sgc0bm89c3-waybar-0.9.2/bin/..waybar-mediaplayer.py-wrapped-wrapped", line 8, in <module>
    gi.require_version('Playerctl', '2.0')
  File "/nix/store/w4mr1ykma079sgdw4bj9x9y3f6ax86mw-python3.8-pygobject-3.36.0/lib/python3.8/site-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Playerctl not available

Thanks for the help cole-h.

cole-h
cole-h approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waybar-mediaplayer.py prints out some playerctl-related warnings, but this doesn't to appear impact functionality, so it should be fine.

https://github.com/NixOS/nixpkgs/pull/88080
1 package built:
waybar

FlorianFranzen
FlorianFranzen approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@FlorianFranzen FlorianFranzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/160

@AndersonTorres AndersonTorres merged commit f7f2120 into NixOS:master May 22, 2020
@bbigras
Copy link
Contributor Author

bbigras commented May 22, 2020

Thank you very much.

@bbigras bbigras deleted the waybar branch May 22, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen FlorianFranzen approved these changes

@cole-h cole-h cole-h approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbigras @nixos-discourse @FlorianFranzen @cole-h @AndersonTorres