Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Script to format the changelog for TT-Forums #143

Closed
wants to merge 1 commit into from

Conversation

FLHerne
Copy link
Contributor

@FLHerne FLHerne commented May 15, 2020

@andythenorth finds it annoying to do by hand.

@@ -145,8 +145,7 @@ Other Changes
- Fix: String encoding with cases was non-deterministic and resulted in differing md5sums for the NewGRF.
- Fix: Rearrange order of string id assignment to keep compatibility.
- Fix: When some IDs depleted, an internal NML error was raised instead of the intended error message.
- Fix: most_common_refit was reading the wrong bits in var 42; read the write bits and rename it to most_common_cargo_type
as it's more accurate; also add most_common_cargo_subtype which also reads var 42 and was previously missing
- Fix: most_common_refit was reading the wrong bits in var 42; read the write bits and rename it to most_common_cargo_type as it's more accurate; also add most_common_cargo_subtype which also reads var 42 and was previously missing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the hard line-wrapping because the rest of the file doesn't use it, and I couldn't be bothered to handle it in the script.

Formats the entire changelog if 'all' is given as an argument,
 otherwise just the most recent release.
@TrueBrain
Copy link
Member

Do such script really belong in these repositories? Where does that end? And I guess it also works with OpenTTD; so do we add our own version there?

In my opinion, mostly only 1 person uses these kind of scripts and know how to use it, and the repository becomes a personal storage for such scripts :)

In result, I am always a bit reluctant about these things. Isn't it better to place this either in a gist or in a separate repositories, with a collection of more of those scripts which are surrounding OpenTTD projects? I know for example we have language backport scripts, BaNaNaS scripts, ...

@andythenorth
Copy link
Contributor

Put the script in my evil shared library? 🙈 🙉 🙊

https://github.com/andythenorth/polar-fox

@LordAro
Copy link
Member

LordAro commented May 17, 2020

It's part of the release process, so I'd say it probably has a place in a proper repo somewhere. Perhaps in OTTD repo itself, with some other scripts (like language backporting)

@FLHerne
Copy link
Contributor Author

FLHerne commented May 18, 2020

Closing. If there's demand we can find somewhere to put it.

@FLHerne FLHerne closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants