New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processing: 3.5.3 -> 3.5.4 | fix / refactor #88034
Conversation
Builds and launches well on NixOS x86_64 provided an oraclejdk8. Some of my sketches have issues with libraries, but that's still better than status quo. Nicely done with the bytecode patch. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also works on i686-linux
afaict
Want me to squash those nit fixes up? |
Yes I think it'd be nice. |
The old expression downloaded `http://download.processing.org/reference.zip` with a fixed hash, and would break when new versions were released. This expression remedies that by using a versioned tarball. Further, it avoids compiling by applying our patch (to avoid the spurious "Not fond of this Java VM" warning message) directly to the compiled `.class` file.
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com> Use fetchzip instead of fetchTarball Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com> Use xorg instead of xlibs Use xorg instead of xlibs Use xorg instead of xlibs
Abstracting out values from the bytecode patch / making it toggleable guards against future changes breaking the derivation.
- Arguments to `lib.map` were reversed. - `mkDerivation` complained about stringifying a set; use variables prefixed with `popup` instead.
OK, got those bugs fixed. |
The update seems to be obsolete by now. You want to rework the fix/refactor part on the current master? |
Will someone actually merge it this time? I'm not really interested in rebasing it on top of master just for it to sit stagnant for another 3 months before this happens again. |
I can feel your pain. I cannot promise anyything but as I am here now I will hopefully see the notification to review/merge it afterwards. If you want to do it in a new PR you can notify me there. |
I marked this as stale due to inactivity. → More info |
The old expression downloaded
http://download.processing.org/reference.zip
with a fixed hash, and would break when new versions were released.This expression remedies that by using a versioned tarball.
Further, it avoids compiling by applying our patch (to avoid the spurious "Not fond of this Java VM" warning message) directly to the compiled
.class
file.Motivation for this change
The old
processing
expression was broken by a change tohttp://download.processing.org/reference.zip
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)