Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing: 3.5.3 -> 3.5.4 | fix / refactor #88034

Closed
wants to merge 4 commits into from

Conversation

9999years
Copy link
Contributor

The old expression downloaded http://download.processing.org/reference.zip with a fixed hash, and would break when new versions were released.

This expression remedies that by using a versioned tarball.

Further, it avoids compiling by applying our patch (to avoid the spurious "Not fond of this Java VM" warning message) directly to the compiled .class file.

Motivation for this change

The old processing expression was broken by a change to http://download.processing.org/reference.zip.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member

Builds and launches well on NixOS x86_64 provided an oraclejdk8. Some of my sketches have issues with libraries, but that's still better than status quo. Nicely done with the bytecode patch. LGTM

Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works on i686-linux afaict

@bbjubjub2494
Copy link
Member

s/xlibs/xorg/g

@9999years
Copy link
Contributor Author

Want me to squash those nit fixes up?

@bbjubjub2494
Copy link
Member

Yes I think it'd be nice.

The old expression downloaded
`http://download.processing.org/reference.zip` with a fixed hash, and
would break when new versions were released.

This expression remedies that by using a versioned tarball.

Further, it avoids compiling by applying our patch (to avoid the
spurious "Not fond of this Java VM" warning message) directly to the
compiled `.class` file.
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>

Use fetchzip instead of fetchTarball

Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>

Use xorg instead of xlibs

Use xorg instead of xlibs

Use xorg instead of xlibs
Abstracting out values from the bytecode patch / making it
toggleable guards against future changes breaking the derivation.
- Arguments to `lib.map` were reversed.
- `mkDerivation` complained about stringifying a set; use variables
  prefixed with `popup` instead.
@9999years
Copy link
Contributor Author

OK, got those bugs fixed.

@Lassulus
Copy link
Member

The update seems to be obsolete by now. You want to rework the fix/refactor part on the current master?

@9999years
Copy link
Contributor Author

Will someone actually merge it this time? I'm not really interested in rebasing it on top of master just for it to sit stagnant for another 3 months before this happens again.

@Lassulus
Copy link
Member

I can feel your pain. I cannot promise anyything but as I am here now I will hopefully see the notification to review/merge it afterwards. If you want to do it in a new PR you can notify me there.
Sadly the nixpkgs repo has to many open PRs and only some people who can merge. Hopefully we can think of better automation/notification to handle the burden. But right now we are just slacking behind the amount of contributions which are happening.

@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@9999years 9999years closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants