Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk8: 8u241 -> 8u251 #88052

Merged
merged 1 commit into from May 18, 2020
Merged

oraclejdk8: 8u241 -> 8u251 #88052

merged 1 commit into from May 18, 2020

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented May 18, 2020 •
edited

Motivation for this change

Upstream update. (Release notes)

Things done

Manually downloaded the 4 archives from oracle and built on x86_64, i686, and aarch64. (using qemu userspace emulation) I haven't been able to build on armv7l but the hash is correct.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" no diff detected
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review May 18, 2020 09:27
@Ma27 Ma27 merged commit c5225b7 into NixOS:master May 18, 2020
@Ma27
Copy link
Member

Ma27 commented May 18, 2020

@lourkeur does it make sense to backport this?

@bbjubjub2494
Copy link
Member Author

@Ma27 I would say probably yes. It's a bugfix release not a feature release. And the old binary is almost impossible to get now.

@Ma27
Copy link
Member

Ma27 commented May 18, 2020

And the old binary is almost impossible to get now.

You're right about that. Just tried this and didn't find it, so the 8u241 is probably useless on 20.03 if you're missing the tarball.

Ported to stable as 9659dbd.

Thanks for your contribution!

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label May 18, 2020
@bbjubjub2494 bbjubjub2494 deleted the bump-oraclejdk8 branch May 18, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbjubjub2494 @Ma27