Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roadtype speed limit values are doubled in scenario editor drop-down menu #8155

Closed
Andrew350 opened this issue May 17, 2020 · 3 comments
Closed

Roadtype speed limit values are doubled in scenario editor drop-down menu #8155

Andrew350 opened this issue May 17, 2020 · 3 comments

Comments

@Andrew350
Copy link

Version of OpenTTD

master-20200517

Expected result

Speed limits are displayed correctly

Actual result

Speed limits are not displayed correctly

Steps to reproduce

  • Load any roadtype NewGRF with speed limits (RattRoads is shown below)
  • Observe speeds shown in the scenario editor menu vs everything else

screenshot#1

The doubling effect only appears on this drop-down menu and does not appear to affect anything functionally; it is merely cosmetic and limited to the scenario editor.
@James103
Copy link
Contributor

I believe I saw that even before 1.10.0 while I was modifying the Cindini scenario with roadtype NewGRFs.

@Yexo
Copy link
Contributor

Yexo commented May 17, 2020

OpenTTD/src/road_gui.cpp

Line 1321 in 2514f43

item->SetParam(1, rti->max_speed / 2);
(toolbar in normal game) has rti->max_speed/2 while

OpenTTD/src/road_gui.cpp

Line 1362 in 2514f43

item->SetParam(1, rti->max_speed);
(toolbar in scenario editor) shows simply rti->max_speed.

Yexo pushed a commit to Yexo/OpenTTD that referenced this issue May 17, 2020
Fix OpenTTD#8155: Roadtype speed limit in toolbar dropdown in scenari…
e638853 
…o editor was doubled.
@James103
Copy link
Contributor

So just a simple copy-paste error / typo in code?

@Yexo Yexo closed this as completed in 587d8e7 May 19, 2020
rasputino pushed a commit to rasputino/OpenTTD that referenced this issue Jun 1, 2020
Fix OpenTTD#8155: Roadtype speed limit in toolbar dropdown in scenari…
611259a 
…o editor was doubled
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Jun 1, 2020
@LordAro
Fix OpenTTD#8155: Roadtype speed limit in toolbar dropdown in scenari…
9702cba 
…o editor was doubled
LordAro pushed a commit that referenced this issue Jun 1, 2020
@LordAro
Fix #8155: Roadtype speed limit in toolbar dropdown in scenario edito…
3d8e68f 
…r was doubled
freprec pushed a commit to freprec/OpenTTD that referenced this issue Jun 19, 2020
@freprec
Fix OpenTTD#8155: Roadtype speed limit in toolbar dropdown in scenari…
cec291f 
…o editor was doubled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yexo @James103 @Andrew350