Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pycuda: bump cudatoolkit dependency, fix boost, fix build #88031

Merged
merged 1 commit into from May 18, 2020
Merged

Pycuda: bump cudatoolkit dependency, fix boost, fix build #88031

merged 1 commit into from May 18, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented May 17, 2020 •
edited

Motivation for this change

Closes #77563

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach mjlbach mentioned this pull request May 17, 2020
Open
6 tasks
@mjlbach mjlbach changed the title Bump cudatoolkit in pycuda derivation, remove boost dependency Pycuda: bump cudatoolkit dependency, remove boost dependency May 17, 2020
@mjlbach mjlbach changed the title Pycuda: bump cudatoolkit dependency, remove boost dependency Pycuda: bump cudatoolkit dependency, remove boost, fix build May 17, 2020
@mjlbach mjlbach changed the title Pycuda: bump cudatoolkit dependency, remove boost, fix build Pycuda: bump cudatoolkit dependency, fix boost, fix build May 17, 2020
@mjlbach
Copy link
Contributor Author

mjlbach commented May 17, 2020

I tested on python 2 and python3 with the examples from the pycuda repo, and it seems to work

@mjlbach mjlbach mentioned this pull request May 17, 2020
Closed
@bhipple
Copy link
Contributor

bhipple commented May 18, 2020

Result of nixpkgs-review pr 88031 1

3 packages built:
- python27Packages.pycuda
- python37Packages.pycuda
- python38Packages.pycuda

@bhipple bhipple merged commit f648016 into NixOS:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pycuda failed to compile during installation
3 participants
@mjlbach @bhipple @Mic92