Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-apcupsd-exporter: unstable-2019-03-14 -> 0.2.0 #89809

Merged
merged 2 commits into from Jun 8, 2020
Merged

prometheus-apcupsd-exporter: unstable-2019-03-14 -> 0.2.0 #89809

merged 2 commits into from Jun 8, 2020

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Jun 8, 2020

Signed-off-by: Matt Layher mdlayher@gmail.com

Motivation for this change
  • I've done some work to bring apcupsd_exporter up to modern Go/Prometheus standards and the existing version is probably pretty broken
  • Switch to buildGoModule and tagged release
  • Add myself as a maintainer
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Binary builds and runs successfully.

[matt@servnerr-3:~/src/nixpkgs]$ nix-build -A prometheus-apcupsd-exporter
these derivations will be built:                                                                 
  /nix/store/vxfj1zydbsmh5j7sg5wn7av9l42drjaq-apcupsd-exporter-0.2.0.drv
building '/nix/store/vxfj1zydbsmh5j7sg5wn7av9l42drjaq-apcupsd-exporter-0.2.0.drv'...
...
/nix/store/kl2h1zmm4rqry56a3mh5dpbgmgg0v3dk-apcupsd-exporter-0.2.0

[matt@servnerr-3:~/src/nixpkgs]$ ./result/bin/apcupsd_exporter -h
Usage of ./result/bin/apcupsd_exporter:
  -apcupsd.addr string
        address of apcupsd Network Information Server (NIS) (default ":3551")
  -apcupsd.network string
        network of apcupsd Network Information Server (NIS): typically "tcp", "tcp4", or "tcp6" (default "tcp")
  -telemetry.addr string
        address for apcupsd exporter (default ":9162")
  -telemetry.path string
        URL path for surfacing collected metrics (default "/metrics")

[matt@servnerr-3:~/src/nixpkgs]$ ./result/bin/apcupsd_exporter
2020/06/08 10:02:48 starting apcupsd exporter on ":9162" for server tcp://:3551

/cc @1000101 and @mmahut per the initial PR: #69140

Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher
Copy link
Member Author

mdlayher commented Jun 8, 2020

@GrahamcOfBorg build prometheus-apcupsd-exporter

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

Result of nixpkgs-review pr 89809 1

1 package built:
- prometheus-apcupsd-exporter

Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants