Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snappy dependency to leveldb. #89852

Merged
merged 2 commits into from Jun 10, 2020
Merged

Add snappy dependency to leveldb. #89852

merged 2 commits into from Jun 10, 2020

Conversation

robinp
Copy link
Contributor

@robinp robinp commented Jun 8, 2020

This is practically required. Without this option, snappy compression is not supported, so

  1. newly created leveldb stores will take more space than needed
  2. existing snappy-compressed stores won't be opened by tools built without the snappy support.

See #89850.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@robinp
Add snappy dependency to leveldb.
6bc3a02 
This is practically required. Without this option, snappy compression is not supported, so
1) newly created leveldb stores will take more space than needed
2) existing snappy-compressed stores won't be opened by tools built without the snappy support.

See NixOS#89850.
@veprbl veprbl linked an issue Jun 9, 2020 that may be closed by this pull request
Leveldb is not compiled with Snappy #89850
Closed
@veprbl
Copy link
Member

veprbl commented Jun 9, 2020

@GrahamcOfBorg build leveldb

@robinp @bhipple
Update pkgs/development/libraries/leveldb/default.nix
e80c461 
To conform to style.

Co-authored-by: Benjamin Hipple <bhipple@protonmail.com>
veprbl
veprbl approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

7 package marked as broken and skipped:
bareos chaps chronos cpp_ethereum marathon mesos spark

3 package failed to build:
caffe python37Packages.caffe python38Packages.caffe

19 package built:
brise ceph ceph-client fcitx-engines.rime gerbil gerbil-unstable haskellPackages.higher-leveldb haskellPackages.leveldb-haskell haskellPackages.leveldb-haskell-fork leveldb libceph librime minetestserver_4 minetestserver_5 python27Packages.plyvel python37Packages.plyvel python38Packages.plyvel sambaFull wiredtiger

@veprbl veprbl merged commit 5ca9a2d into NixOS:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leveldb is not compiled with Snappy
3 participants
@robinp @veprbl @bhipple