Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert f51e66f: creating zip bundle fails for MacOS #8210

Merged
merged 1 commit into from Jun 10, 2020
Merged

Revert f51e66f: creating zip bundle fails for MacOS #8210

merged 1 commit into from Jun 10, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jun 8, 2020 •
edited

make install doesn't work on MacOS yet, so creating zip bundle is impossible.
I think #8189 should solve that

@glx22 glx22 force-pushed the fix_bundle branch 3 times, most recently from 5a51dbb to 60db38d Compare June 8, 2020 23:07
@glx22 glx22 changed the title Fix: MacOS bundle creation (again) Revert f51e66f: creating zip bundle fails for MacOS Jun 8, 2020
@glx22 glx22 marked this pull request as ready for review June 8, 2020 23:29
LordAro
LordAro approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I guess

@glx22 glx22 merged commit 8ef3d8f into OpenTTD:master Jun 10, 2020
@glx22 glx22 deleted the fix_bundle branch June 10, 2020 19:10
@glx22 glx22 restored the fix_bundle branch June 11, 2020 20:10
@glx22 glx22 deleted the fix_bundle branch June 11, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro