New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-keylight-exporter: init at 0.1.1 #89810
Conversation
@GrahamcOfBorg build prometheus-keylight-exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise lgtm. Builds/runs on darwin.
@zowoq Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a NixOS module as well when packaging a new prometheus exporter. Details on how to do that can be found here: https://nixos.org/nixos/manual/index.html#module-services-prometheus-exporters-new-exporter
@Ma27 no problem, I was planning to add one anyway but wasn't sure if it should come in a separate PR. I'll work on that later today hopefully. |
Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@Ma27 @WilliButz module is added, tested, and ready for review! |
@GrahamcOfBorg test prometheus-exporters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module LGTM!
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)