Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] sympa: 6.2.54 -> 6.2.56 #89801

Merged
merged 2 commits into from Jun 17, 2020
Merged

[20.03] sympa: 6.2.54 -> 6.2.56 #89801

merged 2 commits into from Jun 17, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 8, 2020 •
edited

Backport of #89671 and #90067.

ChangeLog: https://github.com/sympa-community/sympa/blob/6.2.56/NEWS.md

Even though the advisory says that Attacker can execute arbitrary code with root privileges, the package nor NixOS module have any setuid wrapper so I believe we're not affected.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata added 1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. labels Jun 8, 2020
@ofborg ofborg bot requested a review from sorki June 8, 2020 12:40
sorki
sorki approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@mmilata mmilata marked this pull request as draft June 10, 2020 14:52
@mmilata
nixos/sympa: fix PATH_INFO splitting for sympa-6.2.56
3f31c0d 
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was
incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has
caused the web interface to return "421 Misdirected Request".

Since 6.2.56 Sympa can do the splitting on its own so we can simply
remove it from nginx configuration.

See also:
- sympa-community/sympa#879
- sympa-community/sympa#910
- sympa-community/sympa-community.github.io#53

(cherry picked from commit bd4e4dd)
@mmilata
Copy link
Member Author

mmilata commented Jun 10, 2020

Also cherry-picked #90067 fixing module bug exposed by the package update.

@mmilata mmilata marked this pull request as ready for review June 10, 2020 15:56
@ofborg ofborg bot requested a review from sorki June 10, 2020 16:03
mmilata added a commit to otevrenamesta/otevrenamesta-cz-configuration that referenced this pull request Jun 10, 2020
@mmilata
sympa: upgrade to 20.03, sympa-6.2.56
cf030a2 
See also: NixOS/nixpkgs#89801
@worldofpeace worldofpeace merged commit 1a11b5e into NixOS:release-20.03 Jun 17, 2020
@mmilata mmilata deleted the 20.03/sympa-6.2.56 branch June 18, 2020 00:04
@mmilata mmilata mentioned this pull request Jun 18, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki Awaiting requested review from sorki

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: module (update) 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @sorki @worldofpeace