Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytorch: 1.4.1 -> 1.5.0 #89802

Merged
merged 1 commit into from Jun 8, 2020
Merged

pythonPackages.pytorch: 1.4.1 -> 1.5.0 #89802

merged 1 commit into from Jun 8, 2020

Conversation

GuillaumeDesforges
Copy link
Contributor

@GuillaumeDesforges GuillaumeDesforges commented Jun 8, 2020 •
edited

Motivation for this change

Update pytorch to 1.5.0

The 1.4.1 version is broken for CUDA builds, see #89403
Also, the Nix package of pytorch on nixpkgs required some patches, but those were fixed in 1.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Testing
$ NIX_PATH="nixpkgs=/home/arsleust/nixpkgs" nix-shell -p python3Packages.pytorch

[nix-shell:~/nixpkgs]$ python
Python 3.7.7 (default, Mar 10 2020, 06:34:06) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> torch.__version__
'1.5.0'
>>> torch.cuda.is_available()
True

pythonPackages.pytorch: 1.4.1 -> 1.5.0
9938052 
Fixes previous bugs that required a patch
Fixes CUDA build, see NixOS#89403
@GuillaumeDesforges GuillaumeDesforges self-assigned this Jun 8, 2020
@ofborg ofborg bot requested review from teh and thoughtpolice June 8, 2020 12:46
@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

cc @mweinelt

@mweinelt
Copy link
Member

mweinelt commented Jun 8, 2020

Yep, I have the same diff locally and it builds.

mweinelt
mweinelt approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tested.

jonringer
jonringer approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/89802
2 packages failed to build:
python37Packages.pyro-ppl python38Packages.pyro-ppl

16 packages built:
python37Packages.ignite python37Packages.pytorch python37Packages.pytorch-metric-learning python37Packages.pytorchWithCuda python37Packages.pywick python37Packages.skorch python37Packages.tensorly python37Packages.torchvision python38Packages.ignite python38Packages.pytorch python38Packages.pytorch-metric-learning python38Packages.pytorchWithCuda python38Packages.pywick python38Packages.skorch python38Packages.tensorly python38Packages.torchvision

@jonringer jonringer merged commit 0574ace into NixOS:master Jun 8, 2020
@jonringer jonringer mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@teh teh Awaiting requested review from teh

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

@GuillaumeDesforges GuillaumeDesforges

Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeDesforges @Mic92 @mweinelt @jonringer