New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: paddings in website footer #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please simplify the code with padding: 3px 5px;
.
It's been 5 minutes, don't be impatient |
Sorry for the delay. I had the first pub visit since months followed by the darkness of the night. :-) [edit] Even someone else will merge this PR I need a clarification. I don't know, how to deploy the two commits. "Squash" or "rebase"? What's the way to go in such case? [/edit] |
Squash, as the second commit is only "fixing" the previous. (If it were any more complicated we'd want to ask the author for a rebase to squash the 2 commits together, but we can do it manually here) |
What's making it so my fix is only being pushed to One possible reason might be that the change is not a critical fix, meaning that it is only pushed to |
When a PR got merged, it moves to staging.openttd.org. Until a new version of the website gets released, merged changes stays in the "staging area". Please stay patient and tuned. :-) |
(It's very unlikely that you'll have to wait until 1.11.0-beta1, which is many months away) |
What's with the (not so) monthly dev posts? Maybe the next gets released before 1.11.0-beta1 (or 1.10.3). :-) |
See #117
They were originally lopsided, but now it's about equal on both sides.
Before:
After: