Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devilutionx: fix build dependency on SDL2 #89843

Closed
wants to merge 2 commits into from
Closed

devilutionx: fix build dependency on SDL2 #89843

wants to merge 2 commits into from

Conversation

karolchmist
Copy link
Member

Motivation for this change

This fixes broken build of devilutionx, which was caused by removing static build of SDL2. Explanation can be found here.

Also, I've added the flag BINARY_RELEASE=ON"to CMake build, which among other things greatly reduces the size of the executable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jun 9, 2020

Upstream requires a static SDL2?

@karolchmist
Copy link
Member Author

I'm not a C/C++ developer, so it's a bit hard for me to know. There is a notion of dynamic SDL2 here, but only for windows AFAIK.

I just managed to make it work with some local upstream changes in their CMakeLists.txt. I'll create an upstream PR and see what happens.

I'm closing this PR for now. Thank you @aanderse for your help!

@karolchmist karolchmist closed this Jun 9, 2020
@dtzWill dtzWill mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karolchmist @aanderse