Add unit tests for rust-ffi #3671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilligan
force-pushed
the
add-rust-ffi-tests
branch
from
16b6d76
to
5cc7843
Compare
|
Looking forward to this :). I'll add some more in #3450 once this is merged. |
Ericson2314
approved these changes
Jun 10, 2020
|
I feel that because the Rust API is still very much a work in progress, it's premature to add tests at this point. (E.g. if we switch to |
|
@edolstra i would say that is maybe even more reason to do so. The idea behind unit tests is not to forever encode the way something is supposed to work without ever changing. Instead it’s supposed to make it easier to do the changes i’d say. If there are changes that will land sometime soon that will break this tests that’s great. That means the tests will be fixed and adjusted and also that they cover relevant code. |
Closed
|
Considering #3702 i am going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds very simple tests for String and Result from rust-ffi.h
Note: The
Resulttest case for Err values should be adjusted suchthat it carries an actual exception. I failed to get that done however.
@edolstra Maybe you know how to do this.