Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matomo: 3.13.5 -> 3.13.6 #89836

Merged
merged 1 commit into from Jul 6, 2020
Merged

matomo: 3.13.5 -> 3.13.6 #89836

merged 1 commit into from Jul 6, 2020

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

https://matomo.org/changelog/matomo-3-13-6

@Kiwi While this is rated a security release, that's only because of a plugin, but plugins do not work on NixOS anyway, and therefore shouldn't need backporting.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test matomo matomo-beta

@ajs124
Copy link
Member

ajs124 commented Jun 8, 2020

plugins do not work on NixOS anyway

I'm just gonna leave this here:

  matomoPackages = (callPackage (builtins.fetchGit {
    url = "https://git.helsinki.tools/helsinki-systems/matomo2nix";
    ref = "master";
  }) {}) // {
    withPlugins = matomoPkg: pluginPkgs: runCommand "matomo-with-plugins" {} ''
      cp -a ${matomoPkg}/. $out
      find $out -type d -exec chmod 755 {} +
      for i in ${lib.concatStringsSep " " pluginPkgs}; do
        cp -a $i/. $out
      done
    '';
  };

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

plugins do not work on NixOS anyway

I'm just gonna leave this here:

Added to the wiki: https://nixos.wiki/wiki/Matomo

@bhipple
Copy link
Contributor

bhipple commented Jul 6, 2020

Result of nixpkgs-review pr 89836 1

2 packages built:
- matomo
- matomo-beta

@bhipple bhipple merged commit 3fd87d3 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants