Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.1.6 -> 6.1.10 #89798

Merged
merged 1 commit into from Jul 21, 2020
Merged

virtualbox: 6.1.6 -> 6.1.10 #89798

merged 1 commit into from Jul 21, 2020

Conversation

nthorne
Copy link
Contributor

@nthorne nthorne commented Jun 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nthorne
Copy link
Contributor Author

nthorne commented Jun 8, 2020

supersedes pull request #88172

@nthorne nthorne mentioned this pull request Jun 8, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from svanderburg and cdepillabout June 8, 2020 11:33
B4dM4n
B4dM4n approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@B4dM4n B4dM4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Build succeeds including kernel 5.7 and VMs are running fine.

@nthorne
Copy link
Contributor Author

nthorne commented Jun 17, 2020

.. is there someone that needs to be pinged, or something else that needs to be done for this one to be merged??

@gloaming
Copy link
Contributor

It builds and VMs run, things seem fine. I did experience a crash while stopping one VM but that might be down to not rebooting after installing, or just chance. LGTM

cc @ambrop72 @flokli @aszlig

@nthorne
Copy link
Contributor Author

nthorne commented Jun 21, 2020

@gloaming i've been running my work VM for a while now using this derivation, and as far as I've been able to tell, there's no regression (auto scaling is as crappy as in any version beyond 6.1.2, though, but there's no obvious regression compared to previous version at least).

@gloaming gloaming mentioned this pull request Jun 21, 2020
Closed
@flokli flokli requested review from blitz and tfc June 21, 2020 20:02
@flokli
Copy link
Contributor

flokli commented Jun 21, 2020

@blitz just wanted to check back on https://github.com/NixOS/nixpkgs/pull/85772#issuecomment-617769606… were you able to take a look at the tests?

@chvp
Copy link
Member

chvp commented Jul 15, 2020

6.1.12 was released yesterday.

@blitz
Copy link
Contributor

blitz commented Jul 20, 2020

@flokli No luck with the tests yet. I'll take some time tomorrow to look into that again. That would simplify testing a lot...

blitz
blitz approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually tested:

  • Windows 10
  • NixOS Plasma LiveCD

Looks great!

@flokli flokli merged commit d5f7c6e into NixOS:master Jul 21, 2020
@flokli
Copy link
Contributor

flokli commented Jul 21, 2020

Alright, merged this in - let's leave 6.1.12 and the tests to (a) separate PR(s).

@nthorne nthorne deleted the virtualbox6110 branch August 3, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blitz blitz blitz approved these changes

@B4dM4n B4dM4n B4dM4n approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nthorne @gloaming @flokli @chvp @blitz @B4dM4n