Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble: 1.3.0 -> 1.3.1 #89797

Merged
merged 1 commit into from Jun 9, 2020
Merged

mumble: 1.3.0 -> 1.3.1 #89797

merged 1 commit into from Jun 9, 2020

Conversation

dali99
Copy link
Member

@dali99 dali99 commented Jun 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@hax404 hax404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client and Server works.

@grahamc grahamc merged commit ac44b7f into NixOS:master Jun 9, 2020
@ajs124
Copy link
Member

ajs124 commented Jun 9, 2020

This should probably be backported, seeing as it contains at least two security fixes: mumble-voip/mumble#4032 and mumble-voip/mumble#4227

@dali99 dali99 mentioned this pull request Jun 9, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants