New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitit: init at 0.13.0.0 #89795
gitit: init at 0.13.0.0 #89795
Conversation
It’s finally got a new release.
This was broken in `haskellPackages` for a long time, but it’s back! Time to give it a place in the toplevel and a prope) treatment: * Semi-static binary * Remove all references to `Paths_` modules of dependencies * gitit tries very hard to have a runtime dependency on GHC, disable that by default. Also added myself as a maintainer, let’s try to keep this working from now on. Fixes NixOS#32377
e5db68c
to
943c220
Compare
cc @P-E-Meunier |
# gitit is unbroken in the latest release | ||
gitit = markUnbroken super.gitit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you submit this PR to the haskell-updates
branch, then you shouldn't need this.
As soon as the daily update CI thing runs, gitit
will be unmarked broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the workings of that written down somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Profpatsch Unfortunately, not as far as I know.
I wrote about it a little in this post:
https://discourse.nixos.org/t/haskellpackages-stm-containers-fails-to-build/5416/4
Also, @maralorn recently created a blog post that included a short section explaining how this works:
https://mpickering.github.io/ide/posts/2020-06-05-ghcide-and-nixpkgs.html
Oh, and I should add that if all you do is use markUnbroken
, because of how the Haskell stuff works, Hydra won't build the derivation for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear I didn't mention the fact that hackage2nix generates the broken flags explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still none the wiser. Is there a step-by-step description of what I have to change where and commit to which branch in what order?
I will merge this one here for now, but am open to doing it the “correct” way if somebody points me to clear documentation that is not spread over multiple Youtube videos and blogposts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Profpatsch I completely understand your frustration. But for this narrow use case it's actually really simple:
- Confirm that package build succeeds, when broken flag is overriden.
- Make a PR against the
haskell-updates
branch, where you remove the package from the array of broken packages inconfiguration-hackage2nix.yaml
. - After merge wait for the daily
hackage-packages.nix
update, which removes the broken flag from the package and removes the flag which disables builds on hydra. - Every friday
haskell-updates
get's merged into master.
Bonus: You can do step 3. on your own in your merge request, but yeah, I think the documentation for that is a youtube video right now.
We really need to make sure all of this is easily discoverable documented.
@GrahamcOfBorg build gitit |
It remains to note that after this merge |
Why wouldn’t it? |
Because |
I just tried compiling
|
I should mention that this error occurred on haskell-updates, not on master. We'll merge haskell-updates to master soon, though. |
Motivation for this change
The new gitit upstream release has unbroken the tool.
The second commit makes it into a top-level semi-static binary with a reasonable default runtime closure. 140 MB oO
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)