Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pygments: 2.5.2 -> 2.6.1 #89845

Closed
wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jun 8, 2020

Motivation for this change

New release: https://github.com/pygments/pygments/releases/tag/2.6.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Jun 8, 2020

Running Pygments on Python 2.x is no longer supported.

I just noticed this is a major breaking change. Wondering how to tackle this.

I'm going for a walk now and will rethink if this was a good idea.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

python 2 is EOL: #77714 (comment)

@jonringer
Copy link
Contributor

I just noticed this is a major breaking change. Wondering how to tackle this.

If there's a use case for the python2 (some application uses it), then it will be worthwhile to freeze the package for the application.

Ideally there would be no uses cases for python2, mentioned above.

@mweinelt
Copy link
Member Author

mweinelt commented Jun 8, 2020

Pretty sure something major is being touched by this.

[0/30670 built, 64/24244/28058 copied (160509.0/183327.7 MiB), 79361.0/92867.2 MiB DL] fetching source from https://cache.nixos.org

A wild guess would be that it's asciidoc and it's touching the whole documentation.

all-packages.nix
--
2314-  asciidoc-full = appendToName "full" (asciidoc.override {
2315:    inherit (python2Packages) pygments;
2316-    texlive = texlive.combine { inherit (texlive) scheme-minimal dvipng; };
2317-    enableStandardFeatures = true;
2318-  });
--
2320-  asciidoc-full-with-plugins = appendToName "full-with-plugins" (asciidoc.override {
2321:    inherit (python2Packages) pygments;
2322-    texlive = texlive.combine { inherit (texlive) scheme-minimal dvipng; };
2323-    enableStandardFeatures = true;
2324-    enableExtraPlugins = true;

@jonringer
Copy link
Contributor

Pretty sure something major is being touched by this.

It's a dependency of sphnix, and a lot of packages use that to generate documentation.

@FRidh
Copy link
Member

FRidh commented Jun 9, 2020

part of #89723

@FRidh FRidh closed this Jun 9, 2020
@mweinelt mweinelt deleted the pygments branch June 24, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants