Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2_mixer: add optional dependency mpg123 #89829

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Jun 8, 2020

Motivation for this change

mpg123 is an optional dependency of SDL2_mixer. Without it, it cannot play [some?] mp3 files.

I did not consider the complexity of making the dependency optional in nixpkgs to be worthwhile, but if there are situations where depending on mpg123 is inconvenient, it would be possible to add an enableMpg123 flag.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Thra11 Thra11 mentioned this pull request Jun 8, 2020
10 tasks
@ofborg ofborg bot requested a review from MP2E June 8, 2020 19:14
@MP2E MP2E merged commit 4cc48e5 into NixOS:master Jun 12, 2020
@MP2E
Copy link

MP2E commented Jun 12, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants