relpipe: init at 0.17.1 #89787

MostAwesomeDude · 2020-06-08T05:38:13Z

Motivation for this change

Things done

MostAwesomeDude · 2020-06-09T06:33:52Z

While testing the functionality in relpipe-in-sql, I tripped over the issue that is now fixed by #89879. That PR doesn't block this one, but does interfere constructively.

Lassulus · 2020-08-22T11:44:32Z

Not sure if the merge commit will cause any noise when merging, Maybe you could remove it?

pkgs/tools/text/relpipe/default.nix

SuperSandro2000 · 2020-12-29T03:02:00Z

pkgs/tools/text/relpipe/default.nix

+      meta = {
+        maintainers = [ stdenv.lib.maintainers.MostAwesomeDude ];
+        homepage = https://relational-pipes.globalcode.info/;
+        license = stdenv.lib.licenses.gpl3;
+        description = "An open data format designed for streaming structured data between two processes";
+      };


Suggested change

meta = {

maintainers = [ stdenv.lib.maintainers.MostAwesomeDude ];

homepage = https://relational-pipes.globalcode.info/;

license = stdenv.lib.licenses.gpl3;

description = "An open data format designed for streaming structured data between two processes";

};

meta = with stdenv.lib; {

description = "An open data format designed for streaming structured data between two processes";

homepage = "https://relational-pipes.globalcode.info/";

license = licenses.gpl3;

maintainers = with maintainers; [ MostAwesomeDude ];

};

@MostAwesomeDude please address this review comment as well.

SuperSandro2000 · 2020-12-29T03:03:18Z

Please remove the merge conflict.

SuperSandro2000 · 2020-12-29T03:07:14Z

Result of nixpkgs-review pr 89787 run on x86_64-linux 1

1 package built:

relpipe

SuperSandro2000 · 2021-01-18T11:00:06Z

Please remove the merge master commit.

Tested a couple of the utilities. I don't have a setup for testing the JACK tools though.

doronbehar

Very good looking package!

pkgs/tools/text/relpipe/default.nix

doronbehar · 2021-08-10T06:00:37Z

pkgs/tools/text/relpipe/default.nix

+  };
+in symlinkJoin {
+  name = "relpipe";
+  paths = [


It would be nice if it was possible to disable some of these packages, to spare some closure size for those who wish so.

Sure. Or we could split them into an attrset. The upstream intent is that a metapackage will have all of the utilities, but there's nothing wrong with exposing them ala carte.

And do a couple fixups so that the package still builds. Co-authored-by: Sandro <sandro.jaeckel@gmail.com> Co-authored-by: Doron Behar <doron.behar@gmail.com>

This is more accurate. Requested from code review.

MostAwesomeDude · 2021-08-22T16:38:55Z

I think that I've handled all review comments, save for the following:

Closure size: Yes, let's go smaller. I don't know what folks would prefer to do, but I would be okay with putting e.g. relpipe.in-csv in there. Do we just make an attrset and merge it into the symlink farm? This seems like a nice feature that doesn't have to block this PR.
Python version: relpipe-tr-python is hardcoded upstream to build against Python 3.6 alone. This can probably be patched later in another PR, if we need more flexibility. I already tried the simple obvious tricks for making the build instructions more flexible, but they did not work.
Rebase: This branch is relatively old for not having any merge conflicts! I don't think I need to rebase yet though.

Thanks for coming with me on this marathon. I'm renaming the PR to indicate that the merge would make 0.17.1 available, not 0.16.

doronbehar · 2021-08-27T16:22:37Z

Rebase: This branch is relatively old for not having any merge conflicts! I don't think I need to rebase yet though.

👍

Closure size: Yes, let's go smaller. I don't know what folks would prefer to do, but I would be okay with putting e.g. relpipe.in-csv in there. Do we just make an attrset and merge it into the symlink farm? This seems like a nice feature that doesn't have to block this PR.

I don't understand the idea, but it'd be nice if you'd allow overriding the derivation in a way that will enable saving some closure size for those who wish so, with this change:

diff --git i/pkgs/tools/text/relpipe/default.nix w/pkgs/tools/text/relpipe/default.nix
index e0603972e92..1f66803413d 100644
--- i/pkgs/tools/text/relpipe/default.nix
+++ w/pkgs/tools/text/relpipe/default.nix
@@ -1,5 +1,19 @@
-{ lib, stdenv, fetchhg, cmake, pkg-config, installShellFiles, symlinkJoin
-, xercesc, libxmlxx, guile_2_2, unixODBC, python36, libjack2 }:
+{ lib
+, stdenv
+, fetchhg
+, cmake
+, pkg-config
+, installShellFiles
+, symlinkJoin
+, xercesc
+, libxmlxx
+, guile_2_2
+, unixODBC
+, python36
+, libjack2
+# Use attribute names strings to disable modules
+, disabledModules ? []
+}:
 
 # Build instructions: https://relational-pipes.globalcode.info/v_0/release-v0.16.xhtml
 let
@@ -37,6 +51,7 @@ let
 
   # Our ordering here loosely follows upstream build order, but Nix frees us
   # from following it strictly.
+  availableModules = {
   lib-common = mkRelPipe {
     pname = "lib-common";
     hash = "18s6nq0n1vn12p1akar12ki18fjp0s3y9vzs87wcdj3dk7v4z7dx";
@@ -185,11 +200,9 @@ let
     hash = "16q9ck2qwyy8f7yqcaab1dicwav325cmajqah9q89xrlkjx3mq2j";
     deps = [ lib-cli lib-common lib-reader libjack2 ];
   };
+  };
 in symlinkJoin {
   name = "relpipe-${version}";
-  paths = [
-    in-fstab in-cli in-xml in-xmltable in-csv in-recfile in-filesystem in-jack
-    tr-cut tr-grep tr-sed tr-awk tr-scheme tr-sql tr-python tr-validator
-    out-nullbyte out-ods out-tabular out-xml out-csv out-asn1 out-recfile out-jack
-  ];
+
+  paths = builtins.attrValues (builtins.removeAttrs availableModules disabledModules);
 }

It's a personal and common preference of mine and a lot of others to use 1 input per line, at the beginning of derivation.

* Python version: `relpipe-tr-python` is hardcoded upstream to build against Python 3.6 alone. This can probably be patched later in another PR, if we need more flexibility. I already tried the simple obvious tricks for making the build instructions more flexible, but they did not work.

Not a blocker IMO too.

SuperSandro2000 · 2021-12-05T05:35:27Z

pkgs/tools/text/relpipe/default.nix

+
+      meta = with lib; {
+        maintainers = [ maintainers.MostAwesomeDude ];
+        homepage = https://relational-pipes.globalcode.info/;


Suggested change

homepage = https://relational-pipes.globalcode.info/;

homepage = "https://relational-pipes.globalcode.info/";

Lassulus · 2022-04-11T21:44:50Z

so, any progress? need any help?

MostAwesomeDude · 2022-04-19T02:42:49Z

Yeah, I'll let somebody else finish this. Thanks for reviewing.

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 8, 2020

MostAwesomeDude mentioned this pull request Jun 9, 2020

unixODBCDrivers: fix sqlite driver to link with sqlite3 #89879

Merged

10 tasks

SuperSandro2000 reviewed Dec 29, 2020

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

MostAwesomeDude added 4 commits February 27, 2021 08:01

relpipe: init at 0.16

cfd1a2a

relpipe: bash completion

3c6f53b

relpipe: Address review feedback.

68f762a

relpipe: 0.16 -> 0.17.1

4cf72af

Tested a couple of the utilities. I don't have a setup for testing the JACK tools though.

MostAwesomeDude force-pushed the relpipes branch from 0506552 to 4cf72af Compare February 27, 2021 20:25

ofborg bot removed the 2.status: merge conflict label Feb 27, 2021

doronbehar reviewed Aug 10, 2021

View reviewed changes

MostAwesomeDude and others added 2 commits August 22, 2021 09:23

Apply suggestions from code review

3d33bf5

And do a couple fixups so that the package still builds. Co-authored-by: Sandro <sandro.jaeckel@gmail.com> Co-authored-by: Doron Behar <doron.behar@gmail.com>

relpipe: Use gpl3Plus for license.

bbb1f4a

This is more accurate. Requested from code review.

MostAwesomeDude force-pushed the relpipes branch from 2aa8833 to bbb1f4a Compare August 22, 2021 16:32

MostAwesomeDude changed the title ~~relpipe: init at 0.16~~ relpipe: init at 0.17.1 Aug 22, 2021

SuperSandro2000 reviewed Dec 5, 2021

View reviewed changes

MostAwesomeDude closed this Apr 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

relpipe: init at 0.17.1 #89787

relpipe: init at 0.17.1 #89787

MostAwesomeDude commented Jun 8, 2020

MostAwesomeDude commented Jun 9, 2020

Lassulus commented Aug 22, 2020

SuperSandro2000 Dec 29, 2020

doronbehar Aug 27, 2021

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Jan 18, 2021

doronbehar left a comment

doronbehar Aug 10, 2021

MostAwesomeDude Aug 22, 2021

MostAwesomeDude commented Aug 22, 2021

doronbehar commented Aug 27, 2021

SuperSandro2000 Dec 5, 2021

Lassulus commented Apr 11, 2022

MostAwesomeDude commented Apr 19, 2022

	homepage = https://relational-pipes.globalcode.info/;
	homepage = "https://relational-pipes.globalcode.info/";

relpipe: init at 0.17.1 #89787

relpipe: init at 0.17.1 #89787

Conversation

MostAwesomeDude commented Jun 8, 2020

Motivation for this change

Things done

MostAwesomeDude commented Jun 9, 2020

Lassulus commented Aug 22, 2020

SuperSandro2000 Dec 29, 2020

Choose a reason for hiding this comment

doronbehar Aug 27, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Dec 29, 2020

SuperSandro2000 commented Jan 18, 2021

doronbehar left a comment

Choose a reason for hiding this comment

doronbehar Aug 10, 2021

Choose a reason for hiding this comment

MostAwesomeDude Aug 22, 2021

Choose a reason for hiding this comment

MostAwesomeDude commented Aug 22, 2021

doronbehar commented Aug 27, 2021

SuperSandro2000 Dec 5, 2021

Choose a reason for hiding this comment

Lassulus commented Apr 11, 2022

MostAwesomeDude commented Apr 19, 2022