Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glusterfs: fix snapshots #87417

Merged
merged 2 commits into from May 9, 2020
Merged

glusterfs: fix snapshots #87417

merged 2 commits into from May 9, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented May 9, 2020

Motivation for this change

Snapshots were not working.

There might be a more elegant way to fixing this than replacing strings in headers, but this works.

cc @nh2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c May 9, 2020 18:44
@7c6f434c
Copy link
Member

7c6f434c commented May 9, 2020

@ofborg test glusterfs

@7c6f434c 7c6f434c merged commit e15ab2c into NixOS:master May 9, 2020
@ajs124 ajs124 deleted the fix/glusterfs_snapshots branch May 9, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @7c6f434c