Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Mlflow backport #87423

Closed
wants to merge 5 commits into from
Closed

[20.03] Mlflow backport #87423

wants to merge 5 commits into from

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented May 9, 2020

Motivation for this change

#74091

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace

@tbenst
Copy link
Contributor Author

tbenst commented May 9, 2020

actually we should wait for #87428, and add to this

@tbenst tbenst marked this pull request as draft May 9, 2020 20:56
@roberth roberth added the 8.has: port to stable A PR already has a backport to the stable release. label May 22, 2020
@stale
Copy link

stale bot commented Nov 19, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 19, 2020
@jonringer
Copy link
Contributor

@tbenst do you still have any interest in this?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 19, 2020
@tbenst
Copy link
Contributor Author

tbenst commented Nov 24, 2020

no longer needed with 20.09, thx!

@tbenst tbenst closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbenst @jonringer @roberth