New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages: make package set extensible #87299
base: master
Are you sure you want to change the base?
Conversation
28ce62d
to
2a53d26
Compare
The one rebuild was I pushed a new version which passes along the |
Unfortunately I'm swamped with a bunch of other stuff, and also no longer work with Perl, so I cannot review this properly but I agree with the general idea of making the package set extensible. |
2a53d26
to
94da90b
Compare
Rebased onto master to resolve merge conflict. |
94da90b
to
3973b05
Compare
Rebased again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Can you provide a code example?
It allows to recursively override or add a dependency in a perlPackages.extend (self: super: with self; {
ModuleBuild = buildPerlPackage {
pname = "Module-Build";
version = "0.4229";
src = fetchurl { ... };
};
}) This can also be done with the let
perl = pkgs.perl.override {
packageOverrides = self: super: with self; {
ModuleBuild = buildPerlPackage {
pname = "Module-Build";
version = "0.4229";
src = pkgs.fetchurl {
url = "mirror://cpan/authors/id/L/LE/LEONT/Module-Build-0.4229.tar.gz";
sha256 = "H+SRps2pFLAbyOWS+qK1QE6fNZFcoVMi+PKo2PkAjBg=";
};
};
};
};
in
perl.pkgs.CPAN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the examples, this is very useful. Tested both approaches OK, and looks good to me.
After looking at the Should I update this PR with a Only the first code example from above would change from |
I marked this as stale due to inactivity. → More info |
I find myself wanting of this. Are folks still amenable to it being merged after a rebase? @B4dM4n if you’re unwilling I can rebase and open a new PR. |
Motivation for this change
Add the same overriding capabilities to the
perlPackages
set thatpythonPackages
andluaPackages
already have.Things done
It uses the same
packageOverrides
argument thatpythonPackages
andluaPackages
also use and keeps the oldconfig.perlPackageOverrides
method.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)