Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/(raspberrypi|uboot)-builder : fix cross using buildPackages #87344

Merged
merged 2 commits into from May 10, 2020
Merged

nixos/(raspberrypi|uboot)-builder : fix cross using buildPackages #87344

merged 2 commits into from May 10, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented May 9, 2020

Motivation for this change

Cross compilation fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sorki sorki mentioned this pull request May 9, 2020
Closed
10 tasks
@sorki sorki added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label May 9, 2020
@sorki sorki force-pushed the cc_extlinux_conf_builder branch from b4e474e to 6b9709e Compare May 9, 2020 08:23
@sorki sorki changed the title nixos/extlinux-conf-builder: fix cross using buildPackages nixos/(raspberrypi|uboot)-builder : fix cross using buildPackages May 9, 2020
@sorki
Copy link
Member Author

sorki commented May 9, 2020

Fixed the same issue with raspberrypi-builder.nix as well.

@bjornfor bjornfor merged commit a6ac6d0 into NixOS:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sorki @bjornfor