Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vips: 0.8.1 -> 0.8.2 #87386

Closed
wants to merge 1 commit into from
Closed

vips: 0.8.1 -> 0.8.2 #87386

wants to merge 1 commit into from

Conversation

ccellado
Copy link
Contributor

@ccellado ccellado commented May 9, 2020

Motivation for this change

New version

Things done

Added library deps
Things done

Removed old patch
Added libheif, libpng

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from KoviRobi May 9, 2020 13:29
bjornfor
bjornfor requested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/squash commits into one.

@ccellado
Copy link
Contributor Author

Please rebase/squash commits into one.

Done.

@ccellado ccellado closed this May 10, 2020
@ccellado ccellado mentioned this pull request May 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor requested changes

@KoviRobi KoviRobi Awaiting requested review from KoviRobi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccellado @bjornfor @taikatytto