Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2-cutter: 1.10.2 -> 1.10.3 #87370

Merged
merged 1 commit into from May 10, 2020
Merged

radare2-cutter: 1.10.2 -> 1.10.3 #87370

merged 1 commit into from May 10, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from makefu May 9, 2020 11:13
@ofborg ofborg bot requested review from 7c6f434c and dtzWill May 9, 2020 11:33
@Mic92 Mic92 changed the title radare2-cutter: 1.10.3 -> 1.10.3 radare2-cutter: 1.10.2 -> 1.10.3 May 9, 2020
@Mic92
Copy link
Member Author

Mic92 commented May 9, 2020

@GrahamcOfBorg build radare2-cutter

makefu
makefu approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested opening /bin/sh, all looks good!
👍

@Ma27 Ma27 merged commit d232eb1 into NixOS:master May 10, 2020
@Mic92 Mic92 deleted the radare2 branch May 11, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @makefu @Ma27