Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashcards v0.1.2 #87408

Merged
merged 2 commits into from May 20, 2020
Merged

bashcards v0.1.2 #87408

merged 2 commits into from May 20, 2020

Conversation

rpearce
Copy link
Contributor

@rpearce rpearce commented May 9, 2020

Motivation for this change

Adds a bash CLI tool I created to practice flash cards (https://github.com/rpearce/bashcards). This is my first new package submission, so please let me know what I can do better.

Things done

✅ Tested using nix-env -i bashcards -f path/to/my/nixpkgs on macOS Catalina

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes May 9, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions, otherwise nice!

pkgs/tools/misc/bashcards/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/bashcards/default.nix Outdated Show resolved Hide resolved
@rpearce rpearce changed the title Bashcards bashcards v0.1.1 May 9, 2020
@rpearce
Copy link
Contributor Author

rpearce commented May 9, 2020 •
edited

If you don't mind, I got one more patch version bump to include version information in the tool!

Edit: all done! Sorry for the noise.

@rpearce rpearce changed the title bashcards v0.1.1 bashcards v0.1.2 May 9, 2020
@Lassulus
Copy link
Member

heyho, can you squash the last 3 commits please? and name it accordingly.
thanks!

@rpearce
maintainers: add rpearce
88c8f0d
@rpearce
bashcards: init at v0.1.2
cc2e800 
Adds bashcards, a CLI tool to practice flashcards.
@rpearce
Copy link
Contributor Author

rpearce commented May 20, 2020

@Lassulus done!

@Lassulus Lassulus merged commit f26e514 into NixOS:master May 20, 2020
@rpearce rpearce deleted the bashcards branch May 20, 2020 12:47
@rpearce rpearce mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rpearce @Lassulus @prusnak