Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melpa-packages: 2020-05-11 #87409

Merged
merged 3 commits into from May 15, 2020
Merged

melpa-packages: 2020-05-11 #87409

merged 3 commits into from May 15, 2020

Conversation

rasendubi
Copy link
Member

@rasendubi rasendubi commented May 9, 2020 •
edited

Things done
  • Manually reviewed generated file to ensure no new errors are introduced
  • Tested with my emacs setup
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rasendubi rasendubi requested a review from adisbladis as a code owner May 9, 2020 17:06
@adisbladis
Copy link
Member

@rasendubi Are you aware of the script update-from-overlay that doesn't just update melpa packages but also updates elpa?
It pulls from https://github.com/nix-community/emacs-overlay, so it's pretty much instant and formats commit messages nicely for you.

@rasendubi rasendubi changed the title melpa-packages: 2020-05-09 melpa-packages: 2020-05-11 May 11, 2020
@rasendubi
Copy link
Member Author

No, I didn't!

I've updated my PR using it and also mentioned it in melpa/elpa-packages.nix so the next soul could find it.

@rasendubi
Copy link
Member Author

ping @adisbladis

@adisbladis adisbladis merged commit e4d710b into NixOS:master May 15, 2020
@adisbladis
Copy link
Member

I've updated my PR using it and also mentioned it in melpa/elpa-packages.nix so the next soul could find it.

Cool, thanks!

@timor
Copy link
Member

timor commented Jun 25, 2020

Is there a policy about backporting melpa into current NixOS releases?
E.g. at the time of writing this, 20.03 contains a version of magit which has some issues that have been fixed in the version present in this commit. Is there some kind of process to verify that the melpa/elpa set is sane, or ist just being updated every now and then?

@adisbladis
Copy link
Member

@timor There is no policy around this, no. Typically backporting Emacs packages is not done but there is nothing stopping anyone from doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasendubi @adisbladis @timor