Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8119, f538179: Update docking tile area when placing a diagonal rail next to a dock end #8124

Merged

Conversation

SamuXarick
Copy link
Contributor

To do: test whether desync issue is solved

@SamuXarick SamuXarick force-pushed the rebuild-docking-tile-area-on-building-rail branch from 7a5a473 to 8767a13 Compare May 8, 2020 15:22
@SamuXarick SamuXarick changed the title Fix f538179, #8119: Update docking tile area when placing a diagonal rail next to a dock end Fix #8119, f538179: Update docking tile area when placing a diagonal rail next to a dock end May 8, 2020
@LordAro LordAro requested review from frosch123 and Yexo May 9, 2020 07:45
@LordAro
Copy link
Member

LordAro commented May 9, 2020

Looks like the CI failed to start - can you rebase?

@SamuXarick SamuXarick force-pushed the rebuild-docking-tile-area-on-building-rail branch from 8767a13 to 2fd942c Compare May 9, 2020 09:28
Copy link
Contributor

@Yexo Yexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this works on the test-scenario from #8119.

Copy link
Member

@frosch123 frosch123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other usages of SetDockingTile look correct, so indeed only this one occurence.

@glx22 glx22 merged commit a95fbd5 into OpenTTD:master May 9, 2020
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 10, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 10, 2020
LordAro pushed a commit that referenced this pull request Jun 1, 2020
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jul 27, 2020
@SamuXarick SamuXarick deleted the rebuild-docking-tile-area-on-building-rail branch December 19, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants