Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

J addons #87376

Closed
wants to merge 4 commits into from
Closed

J addons #87376

wants to merge 4 commits into from

Conversation

AshyIsMe
Copy link
Contributor

@AshyIsMe AshyIsMe commented May 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AshyIsMe
j: convert_json and general_dirutils addons
eb70abf 
Added 2 of the jsoftware addons to the j package.
The buildJAddonGitHub nix function can be used to build the standard j
packages from the github.com/jsoftware/addonrepos list.
It does not yet handle linking to any dependencies.
@AshyIsMe
j: added general_dirtrees addon
c131f9c 
The installPhase script is ugly and hard coded at the moment still.
This should be cleaned up to keep a list of the addons and loop
through it to copy in the outputs.
@AshyIsMe
j: added a few more addons
d165d61 
Still only pure j addons working with this method.
@AshyIsMe
j: include all addons
37e7c8c 
Adds a script to help generate the addon list.
@ofborg ofborg bot requested review from 7c6f434c and Synthetica9 May 9, 2020 12:18
@7c6f434c
Copy link
Member

7c6f434c commented May 9, 2020

Hm. I believed install command can create intermediate directories, was I wrong? And maybe that copying part could also be generated as copy-addons.sh so that the update makes sure it is in sync and then the expression just goes sh ${./copy-addons.sh}?

@AshyIsMe
Copy link
Contributor Author

AshyIsMe commented May 9, 2020

Yes this PR is fairly incomplete so I will close it and clean this up before sending another PR.
There's been some discussions in #jsoftware on freenode about structuring this similar to nixpkgs/pkgs/development/lua-modules

@AshyIsMe AshyIsMe closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AshyIsMe @7c6f434c